Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ECAL DCC desync DQM trend plots and update the DQM threshold for Integrity summary #45766

Merged
merged 2 commits into from
Sep 6, 2024
Merged

Add ECAL DCC desync DQM trend plots and update the DQM threshold for Integrity summary #45766

merged 2 commits into from
Sep 6, 2024

Conversation

kyungminparkdrums
Copy link

PR description:

This PR includes two changes related to ECAL DQM:
[1] Adding the ECAL DQM plots for the trend of DCC-SRP and DCC-TCC desync in ECAL DQM (in Layout/01 Raw Data and Layout/11 Trend).
[2] Update the DQM threshold for the integrity summary for ECAL supermodule, such that if more than 1% of the supermodule has DCC-SRP or DCC-TCC desync errors it is flagged as bad (previous threshold: more than 50 desync errors).

PR validation:

PR is validated by running the ECAL online DQM configuration and verifying the plots on a test DQM GUI.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

This is the Master PR. Backports are made to 14_0_13 in PR #45761

@cmsbuild cmsbuild added this to the CMSSW_14_1_X milestone Aug 21, 2024
@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 21, 2024 •
edited
Loading

cms-bot internal usage

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45766/41480

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @kyungminparkdrums for master.

It involves the following packages:

  • DQM/EcalMonitorClient (dqm)
  • DQM/EcalMonitorTasks (dqm)

@antoniovagnerini, @cmsbuild, @nothingface0, @rvenditti, @syuvivida, @tjavaid can you please review it and eventually sign? Thanks.
@ReyerBand, @argiro, @rchatter, @thomreis, @wang0jin this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@kyungminparkdrums kyungminparkdrums mentioned this pull request Aug 21, 2024
Merged
@tjavaid
Copy link

tjavaid commented Aug 21, 2024

please test

@tjavaid tjavaid mentioned this pull request Aug 21, 2024
Merged
@cmsbuild
Copy link
Contributor

-1

Failed Tests: RelVals-INPUT
Size: This PR adds an extra 24KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3ccdbb/41063/summary.html
COMMIT: 17c1632
CMSSW: CMSSW_14_1_X_2024-08-21-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/45766/41063/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

The relvals timed out after 4 hours.

Comparison Summary

Summary:

  • You potentially removed 3 lines from the logs
  • Reco comparison results: 20 differences found in the comparisons
  • DQMHistoTests: Total files compared: 44
  • DQMHistoTests: Total histograms compared: 3324622
  • DQMHistoTests: Total failures: 1278
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3323324
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 237.1949999999998 KiB( 43 files compared)
  • DQMHistoSizes: changed ( 1000.0,... ): 6.777 KiB Ecal/Trends
  • Checked 191 log files, 161 edm output root files, 44 DQM output files
  • TriggerResults: no differences found

@cmsbuild
Copy link
Contributor

Milestone for this pull request has been moved to CMSSW_14_2_X. Please open a backport if it should also go in to CMSSW_14_1_X.

@cmsbuild cmsbuild modified the milestones: CMSSW_14_1_X, CMSSW_14_2_X Aug 27, 2024
@tjavaid
Copy link

tjavaid commented Aug 29, 2024

please test

@cmsbuild cmsbuild modified the milestones: CMSSW_14_1_X, CMSSW_14_2_X Aug 29, 2024
@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 12KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3ccdbb/41188/summary.html
COMMIT: 17c1632
CMSSW: CMSSW_14_2_X_2024-08-28-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/45766/41188/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 2 lines from the logs
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 44
  • DQMHistoTests: Total histograms compared: 3328202
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3328179
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 237.1949999999998 KiB( 43 files compared)
  • DQMHistoSizes: changed ( 1000.0,... ): 6.777 KiB Ecal/Trends
  • Checked 193 log files, 163 edm output root files, 44 DQM output files
  • TriggerResults: no differences found

@tjavaid
Copy link

tjavaid commented Sep 5, 2024

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 5, 2024

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 230ba98 into cms-sw:master Sep 6, 2024
11 checks passed
@kyungminparkdrums kyungminparkdrums mentioned this pull request Sep 6, 2024
Merged
@kyungminparkdrums
Copy link
Author

@tjavaid The PR for the backport to 14_1_X is open here: #45933

@cmsbuild cmsbuild mentioned this pull request Sep 7, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
code-checks-approved dqm-approved fully-signed orp-approved tests-approved
Projects
None yet
Milestone
CMSSW_14_2_X
Development

Successfully merging this pull request may close these issues.
4 participants
@kyungminparkdrums @cmsbuild @tjavaid @mandrenguyen